From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
jon.maloy@ericsson.com, maloy@donjonn.com,
ying.xue@windriver.com, paul.gortmaker@windriver.com,
richard.alpe@ericsson.com
Subject: Re: [PATCH] tipc: fix regression bug where node events are not being generated
Date: Thu, 03 Apr 2014 16:04:41 -0400 (EDT) [thread overview]
Message-ID: <20140403.160441.1850317737194356140.davem@davemloft.net> (raw)
In-Reply-To: <1396506481-17362-1-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Thu, 3 Apr 2014 08:28:01 +0200
> From: Erik Hugne <erik.hugne@ericsson.com>
>
> Commit 5902385a2440a55f005b266c93e0bb9398e5a62b ("tipc: obsolete
> the remote management feature") introduces a regression where node
> topology events are not being generated because the publication
> that triggers this: {0, <z.c.n>, <z.c.n>} is no longer available.
> This will break applications that rely on node events to discover
> when nodes join/leave a cluster.
>
> We fix this by advertising the node publication when TIPC enters
> networking mode, and withdraws it upon shutdown.
>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
> Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
> Reviewed-by: Ying Xue <ying.xue@windriver.com>
Applied, thanks.
prev parent reply other threads:[~2014-04-03 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 6:28 [PATCH] tipc: fix regression bug where node events are not being generated erik.hugne
2014-04-03 6:37 ` Ying Xue
2014-04-03 20:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403.160441.1850317737194356140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).