From: David Miller <davem@davemloft.net>
To: zheng.x.li@oracle.com
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, fubar@us.ibm.com,
andy@greyhouse.net, vfalico@redhat.com,
linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: Re: [PATCH v3] bonding: Inactive slaves should keep inactive flag's value
Date: Fri, 04 Apr 2014 10:04:38 -0400 (EDT) [thread overview]
Message-ID: <20140404.100438.264462269855449623.davem@davemloft.net> (raw)
In-Reply-To: <1396407708-4056-1-git-send-email-zheng.x.li@oracle.com>
From: Zheng Li <zheng.x.li@oracle.com>
Date: Wed, 2 Apr 2014 11:01:48 +0800
> bond_open is not setting the inactive flag correctly for some modes (alb and
> tlb), resulting in error behavior if the bond has been administratively set
> down and then back up. This effect should not occur when slaves are added while
> the bond is up; it's something that only happens after a down/up bounce of the
> bond.
>
> For example, in bond tlb or alb mode, domu send some ARP request which go out
> from dom0 bond's active slave, then the ARP broadcast request packets go back to
> inactive slave from switch, because the inactive slave's inactive flag is zero,
> kernel will receive the packets and pass them to bridge that cause dom0's bridge
> map domu's MAC address to port of bond, bridge should map domu's MAC to port of
> vif.
>
> Signed-off-by: Zheng Li <zheng.x.li@oracle.com>
> Signed-off-by: Jay Vosburgh <j.vosburgh@gmail.com>
Applied.
prev parent reply other threads:[~2014-04-04 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 3:01 [PATCH v3] bonding: Inactive slaves should keep inactive flag's value Zheng Li
2014-04-03 2:16 ` zheng.li
2014-04-04 14:04 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404.100438.264462269855449623.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=fubar@us.ibm.com \
--cc=j.vosburgh@gmail.com \
--cc=joe.jin@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
--cc=zheng.x.li@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).