From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH next-next 4/6] net: Call skb_checksum_init in IPv4
Date: Mon, 07 Apr 2014 13:13:56 -0400 (EDT) [thread overview]
Message-ID: <20140407.131356.1060173493402786873.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1404041721170.21628@tomh.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Fri, 4 Apr 2014 17:27:36 -0700 (PDT)
> @@ -1454,6 +1454,13 @@ out_unlock:
> return err;
> }
>
> +__wsum inet_pseudo_compute(struct sk_buff *skb, int proto)
> +{
> + return csum_tcpudp_nofold(ip_hdr(skb)->saddr, ip_hdr(skb)->daddr,
> + skb->len, proto, 0);
> +}
> +EXPORT_SYMBOL(inet_pseudo_compute);
This is just adjusting arguments passed into to another inline
function, please put this in a header and make it an inline too.
next prev parent reply other threads:[~2014-04-07 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 0:27 [PATCH next-next 4/6] net: Call skb_checksum_init in IPv4 Tom Herbert
2014-04-07 17:13 ` David Miller [this message]
2014-04-07 17:30 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407.131356.1060173493402786873.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).