From: David Miller <davem@davemloft.net>
To: vfalico@redhat.com
Cc: netdev@vger.kernel.org, dborkman@redhat.com, edumazet@google.com,
nicolas.dichtel@6wind.com, jiri@resnulli.us,
stephen@networkplumber.org, hkchu@google.com
Subject: Re: [PATCH net] netdev: remove potentially harmful checks
Date: Mon, 07 Apr 2014 15:52:46 -0400 (EDT) [thread overview]
Message-ID: <20140407.155246.1115800673081965447.davem@davemloft.net> (raw)
In-Reply-To: <1396862712-5225-1-git-send-email-vfalico@redhat.com>
From: Veaceslav Falico <vfalico@redhat.com>
Date: Mon, 7 Apr 2014 11:25:12 +0200
> Currently we're checking a variable for != NULL after actually
> dereferencing it, in netdev_lower_get_next_private*().
>
> It's counter-intuitive at best, and can lead to faulty usage (as it implies
> that the variable can be NULL), so fix it by removing the useless checks.
>
> Reported-by: Daniel Borkmann <dborkman@redhat.com>
> CC: "David S. Miller" <davem@davemloft.net>
> CC: Eric Dumazet <edumazet@google.com>
> CC: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> CC: Jiri Pirko <jiri@resnulli.us>
> CC: stephen hemminger <stephen@networkplumber.org>
> CC: Jerry Chu <hkchu@google.com>
> Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2014-04-07 19:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 9:25 [PATCH net] netdev: remove potentially harmful checks Veaceslav Falico
2014-04-07 19:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407.155246.1115800673081965447.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=stephen@networkplumber.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).