Re: [PATCH net] Remove unnecessary condition check in phy

[David Miller <davem@davemloft.net>]

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Mon, 7 Apr 2014 18:09:00 -0700

> 2014-04-07 11:58 GMT-07:00 David Miller <davem@davemloft.net>:
>> From: Balakumaran Kannan <kumaran.4353@gmail.com>
>> Date: Sat, 05 Apr 2014 13:00:16 +0530
>>
>>> This condition check makes no difference in the code flow since 3.10
>>>
>>> Signed-off-by: Balakumaran Kannan <kumaran.4353@gmail.com>
>>
>> The big questions is, was this intentional?
> 
> It was before a33e6112d9b0 ("phy: Elimination the forced speed
> reduction algorithm") because the PHY having PHY_HAS_MAGICANEG set
> would not go through the PHY speed reduction algorithm. Now, this is
> useless as there is a subsequent break and no conditional code based
> on PHY_HAS_MAGICANEG (which means that we should also kill its usage
> at some point).

Yep, I read through the history and that's why I noticed the patch didn't
apply, I was about to apply it :-)

> Feel free to add my reviewed-by tag after fixing the mangling David spotted.
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Will do, thanks Florian.