* Re: i40e: Add code to handle FD table full condition
[not found] <20140403052019.CFC67661245@gitolite.kernel.org>
@ 2014-04-04 14:59 ` Dave Jones
2014-04-08 4:31 ` Jesse Brandeburg
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2014-04-04 14:59 UTC (permalink / raw)
To: netdev; +Cc: anjali.singhai, jeffrey.t.kirsher
On Thu, Apr 03, 2014 at 05:20:19AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
> Commit: 55a5e60b9f583f64a6c95cfe869dd2d65ae53a95
> Parent: 61dade7e9201162cba683cff103cebbdf06655d4
> Author: Anjali Singhai Jain <anjali.singhai@intel.com>
> AuthorDate: Wed Feb 12 06:33:25 2014 +0000
> Committer: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CommitDate: Fri Mar 14 16:30:03 2014 -0700
>
> i40e: Add code to handle FD table full condition
...
> + /* Turn off ATR first */
> + if (pf->flags | I40E_FLAG_FD_ATR_ENABLED) {
This condition is always true.
Did you mean to write something like
if (pf->flags & ~I40E_FLAG_FD_ATR_ENABLED)
perhaps ?
Same with the
} else if (pf->flags | I40E_FLAG_FD_SB_ENABLED) {
that pairs with it.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: i40e: Add code to handle FD table full condition
2014-04-04 14:59 ` i40e: Add code to handle FD table full condition Dave Jones
@ 2014-04-08 4:31 ` Jesse Brandeburg
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Brandeburg @ 2014-04-08 4:31 UTC (permalink / raw)
To: Dave Jones; +Cc: netdev, anjali.singhai, jeffrey.t.kirsher, jesse.brandeburg
On Fri, 4 Apr 2014 10:59:30 -0400
Dave Jones <davej@redhat.com> wrote:
> > + /* Turn off ATR first */
> > + if (pf->flags | I40E_FLAG_FD_ATR_ENABLED) {
>
> This condition is always true.
Ouch, that is a nice catch Dave! We will submit a fix shortly. I'll
cook something up now and push it to JeffK for a quick check before it
gets upstream.
Thanks!
Jesse
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-08 4:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140403052019.CFC67661245@gitolite.kernel.org>
2014-04-04 14:59 ` i40e: Add code to handle FD table full condition Dave Jones
2014-04-08 4:31 ` Jesse Brandeburg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).