From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: stephen@networkplumber.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] net: Add __dev_forward_skb
Date: Tue, 08 Apr 2014 12:27:39 -0400 (EDT) [thread overview]
Message-ID: <20140408.122739.1963541036894784.davem@davemloft.net> (raw)
In-Reply-To: <20140408071518.GA2694@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Tue, 8 Apr 2014 15:15:18 +0800
> On Mon, Apr 07, 2014 at 11:48:54AM -0700, Stephen Hemminger wrote:
>> On Mon, 07 Apr 2014 15:55:35 +0800
>> Herbert Xu <herbert@gondor.apana.org.au> wrote:
>>
>> > +}
>> > +EXPORT_SYMBOL_GPL(__dev_forward_skb);
>> > +
>>
>> Don't export a symbol without a followup patch that uses it.
>
> Sorry but I screwed the threading so the follow-up patch is in its
> own thread. But I assure you that this symbol is used in the
> follow-up :)
Yeah I was going to mention that to Stephen too :-)
next prev parent reply other threads:[~2014-04-08 16:27 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<20140407075347.GA26461@gondor.apana.org.au>
2014-04-07 7:55 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-07 18:48 ` Stephen Hemminger
2014-04-08 7:15 ` Herbert Xu
2014-04-08 16:27 ` David Miller [this message]
2014-04-07 7:55 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-07 14:07 ` Eric Dumazet
2014-04-07 14:23 ` Herbert Xu
2014-04-08 16:48 ` Ben Greear
2014-04-08 17:23 ` Herbert Xu
2014-04-11 1:40 ` David Miller
2014-04-11 1:59 ` Herbert Xu
2014-04-11 2:09 ` Eric Dumazet
2014-04-11 2:13 ` Herbert Xu
2014-04-11 8:45 ` David Laight
2014-04-11 16:11 ` Ben Greear
2014-04-11 16:20 ` Ben Greear
2014-04-11 16:17 ` Ben Greear
2014-04-08 16:55 ` Stephen Hemminger
2014-04-08 17:14 ` Joe Perches
2014-04-09 8:50 ` Herbert Xu
2014-04-09 10:10 ` David Laight
2014-04-10 12:59 ` Herbert Xu
2014-04-10 14:50 ` David Laight
2014-04-07 7:53 [0/2] macvlan: Handle broadcasts in " Herbert Xu
2014-04-17 5:45 ` [PATCH 1/2] net: Add __dev_forward_skb Herbert Xu
2014-04-20 22:19 ` David Miller
2014-04-17 5:45 ` [PATCH 2/2] macvlan: Move broadcasts into a work queue Herbert Xu
2014-04-20 22:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408.122739.1963541036894784.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).