netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tobias@waldekranz.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] phylib: export phy_suspend and phy_resume
Date: Tue, 08 Apr 2014 12:29:53 -0400 (EDT)	[thread overview]
Message-ID: <20140408.122953.1708326631498329706.davem@davemloft.net> (raw)
In-Reply-To: <20140408071101.GA14453@gmail.com>

From: Tobias Waldekranz <tobias@waldekranz.com>
Date: Tue, 8 Apr 2014 09:11:01 +0200

> These functions are exported in include/linux/phy.h but the symbol
> exports where missing.
> 
> Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com>

Because they are only used in places where module exports are unnecessary.
Presence in foo.h does not automatically mean the symbol should be
exported to modules.

If you come up with a use case that requires the module export, submit
it along with a patch like this.

But for now I'm not applying this, sorry.

  parent reply	other threads:[~2014-04-08 16:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-08  7:11 [PATCH] phylib: export phy_suspend and phy_resume Tobias Waldekranz
2014-04-08 15:26 ` Florian Fainelli
2014-04-08 17:04   ` David Miller
2014-04-08 16:29 ` David Miller [this message]
2014-04-08 17:07   ` Tobias Waldekranz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140408.122953.1708326631498329706.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tobias@waldekranz.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).