From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, ebiederm@xmission.com, ja@ssi.bg,
cwang@twopensource.com
Subject: Re: [Patch net] ipv4: fib: check forwarding before checking send_redirects
Date: Tue, 08 Apr 2014 18:04:03 -0400 (EDT) [thread overview]
Message-ID: <20140408.180403.2032592427150449635.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpXkmU9qw_KPeMPnE0KGbcCWo5R=Le7HsizyiuRJVkKshA@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Tue, 8 Apr 2014 14:50:09 -0700
> Which part am I missing?
Please stop looking at this conditional, I'm begging you.
Instead, concentrate on why __fib_validate_source() is rejecting
your packets.
The code must function correctly even if __fib_validate_source()
is invoked unconditionally, all the time, for all non-IPSEC
packets.
next prev parent reply other threads:[~2014-04-08 22:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 19:31 [Patch net] ipv4: fib: check forwarding before checking send_redirects Cong Wang
2014-04-08 20:43 ` David Miller
2014-04-08 21:17 ` Cong Wang
2014-04-08 21:23 ` David Miller
2014-04-08 21:50 ` Cong Wang
2014-04-08 22:04 ` David Miller [this message]
2014-04-08 22:15 ` Julian Anastasov
2014-04-08 22:55 ` Cong Wang
2014-04-09 8:03 ` Julian Anastasov
2014-04-11 19:11 ` Cong Wang
2014-04-12 5:32 ` Rex Ge
2014-04-13 14:57 ` Julian Anastasov
2014-04-14 22:59 ` Cong Wang
2014-04-12 9:52 ` Rex Ge
2014-04-08 22:03 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140408.180403.2032592427150449635.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=ebiederm@xmission.com \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).