From: David Miller <davem@davemloft.net>
To: xiaoming.wang@intel.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
dongxing.zhang@intel.com
Subject: Re: [PATCH] net: ipv4: current group_info should be put after using.
Date: Thu, 10 Apr 2014 23:11:43 -0400 (EDT) [thread overview]
Message-ID: <20140410.231143.457143731030572105.davem@davemloft.net> (raw)
In-Reply-To: <1397232638.20759.28.camel@wxm-ubuntu>
From: "Wang, Xiaoming" <xiaoming.wang@intel.com>
Date: Fri, 11 Apr 2014 12:10:38 -0400
> +EXIT:
Do not use all CAPS names for local labels.
Make the label, in lower case, say something about
what state needs to be released at that point.
Something like "out_release_group:"
next prev parent reply other threads:[~2014-04-11 3:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 16:10 [PATCH] net: ipv4: current group_info should be put after using Wang, Xiaoming
2014-04-11 3:11 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-11 17:37 Wang, Xiaoming
2014-04-11 8:35 ` Mateusz Guzik
2014-04-11 13:33 ` Mateusz Guzik
2014-04-12 2:53 Wang, Xiaoming
2014-04-11 13:50 ` Mateusz Guzik
2014-04-12 20:57 ` David Miller
2014-04-14 16:30 Wang, Xiaoming
2014-04-14 2:54 ` David Miller
2014-05-11 21:55 ` Mateusz Guzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410.231143.457143731030572105.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chuansheng.liu@intel.com \
--cc=dongxing.zhang@intel.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xiaoming.wang@intel.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).