From: Jack Morgenstein <jackm@dev.mellanox.co.il>
To: Wei Yang <weiyang@linux.vnet.ibm.com>
Cc: linux-pci@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, Bjorn Helgaas <bhelgaas@google.com>,
Amir Vadai <amirv@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>
Subject: Re: [PATCH V1 net] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()
Date: Thu, 10 Apr 2014 15:33:55 +0300 [thread overview]
Message-ID: <20140410153355.0ca4348f@jpm-OptiPlex-GX620> (raw)
In-Reply-To: <1397121924-14813-1-git-send-email-weiyang@linux.vnet.ibm.com>
On Thu, 10 Apr 2014 17:25:24 +0800
Wei Yang <weiyang@linux.vnet.ibm.com> wrote:
> pci_match_id() just match the static pci_device_id, which may return
> NULL if someone binds the driver to a device manually using
> /sys/bus/pci/drivers/.../new_id.
>
> This patch wrap up a helper function __mlx4_remove_one() which does
> the tear down function but preserve the drv_data. Functions like
> mlx4_pci_err_detected() and mlx4_restart_one() will call this one
> with out releasing drvdata.
>
> Fixes: 97a5221 "net/mlx4_core: pass pci_device_id.driver_data to
> __mlx4_init_one during reset".
>
> CC: Bjorn Helgaas <bhelgaas@google.com>
> CC: Amir Vadai <amirv@mellanox.com>
> CC: Jack Morgenstein <jackm@dev.mellanox.co.il>
> CC: Or Gerlitz <ogerlitz@mellanox.com>
> Signed-off-by: Wei Yang <weiyang@linux.vnet.ibm.com>
Acked-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
next prev parent reply other threads:[~2014-04-10 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 9:25 [PATCH V1 net] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one() Wei Yang
2014-04-10 12:33 ` Jack Morgenstein [this message]
2014-04-11 20:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410153355.0ca4348f@jpm-OptiPlex-GX620 \
--to=jackm@dev.mellanox.co.il \
--cc=amirv@mellanox.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox