netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Bonding Remove debug_fs files when module init fails
@ 2014-04-09 10:52 Thomas Richter
  2014-04-09 19:53 ` Jay Vosburgh
  2014-04-11 19:09 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Thomas Richter @ 2014-04-09 10:52 UTC (permalink / raw)
  To: netdev; +Cc: Thomas Richter

Remove the bonding debug_fs entries when the
module initialization fails. The debug_fs
entries should be removed together with all other
already allocated resources.

Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
---
 drivers/net/bonding/bond_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 95a6ca7..c11e7b7 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -4492,6 +4492,7 @@ static int __init bonding_init(void)
 out:
 	return res;
 err:
+	bond_destroy_debugfs();
 	bond_netlink_fini();
 err_link:
 	unregister_pernet_subsys(&bond_net_ops);
-- 
1.9.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bonding Remove debug_fs files when module init fails
  2014-04-09 10:52 [PATCH] Bonding Remove debug_fs files when module init fails Thomas Richter
@ 2014-04-09 19:53 ` Jay Vosburgh
  2014-04-11 19:09 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Jay Vosburgh @ 2014-04-09 19:53 UTC (permalink / raw)
  To: Thomas Richter; +Cc: netdev

Thomas Richter <tmricht@linux.vnet.ibm.com> wrote:

>Remove the bonding debug_fs entries when the
>module initialization fails. The debug_fs
>entries should be removed together with all other
>already allocated resources.
>
>Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>

Signed-off-by: Jay Vosburgh <j.vosburgh@gmail.com>

>---
> drivers/net/bonding/bond_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 95a6ca7..c11e7b7 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -4492,6 +4492,7 @@ static int __init bonding_init(void)
> out:
> 	return res;
> err:
>+	bond_destroy_debugfs();
> 	bond_netlink_fini();
> err_link:
> 	unregister_pernet_subsys(&bond_net_ops);
>-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Bonding Remove debug_fs files when module init fails
  2014-04-09 10:52 [PATCH] Bonding Remove debug_fs files when module init fails Thomas Richter
  2014-04-09 19:53 ` Jay Vosburgh
@ 2014-04-11 19:09 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-04-11 19:09 UTC (permalink / raw)
  To: tmricht; +Cc: netdev

From: Thomas Richter <tmricht@linux.vnet.ibm.com>
Date: Wed,  9 Apr 2014 12:52:59 +0200

> Remove the bonding debug_fs entries when the
> module initialization fails. The debug_fs
> entries should be removed together with all other
> already allocated resources.
> 
> Signed-off-by: Thomas Richter <tmricht@linux.vnet.ibm.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-04-11 19:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 10:52 [PATCH] Bonding Remove debug_fs files when module init fails Thomas Richter
2014-04-09 19:53 ` Jay Vosburgh
2014-04-11 19:09 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).