From: David Miller <davem@davemloft.net>
To: nicolas.dichtel@6wind.com
Cc: netdev@vger.kernel.org, xeb@mail.ru
Subject: Re: [PATCH] ip6_gre: don't allow to remove the fb_tunnel_dev
Date: Tue, 15 Apr 2014 00:04:04 -0400 (EDT) [thread overview]
Message-ID: <20140415.000404.2110427476393772943.davem@davemloft.net> (raw)
In-Reply-To: <1397488298-19931-1-git-send-email-nicolas.dichtel@6wind.com>
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Date: Mon, 14 Apr 2014 17:11:38 +0200
> It's possible to remove the FB tunnel with the command 'ip link del ip6gre0' but
> this is unsafe, the module always supposes that this device exists. For example,
> ip6gre_tunnel_lookup() may use it unconditionally.
>
> Let's add a rtnl handler for dellink, which will never remove the FB tunnel (we
> let ip6gre_destroy_tunnels() do the job).
>
> Introduced by commit c12b395a4664 ("gre: Support GRE over IPv6").
>
> CC: Dmitry Kozlov <xeb@mail.ru>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
I don't see how we ever get rid of fb_tunnel_dev and can therefore
remove the module successfully.
It is created by the per-netns initialization, but since it isn't
added to the hashes I don't see how the per-netns exit code can
end up unregistering and freeing it up.
How is this supposed to work?
next prev parent reply other threads:[~2014-04-15 4:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 15:11 [PATCH] ip6_gre: don't allow to remove the fb_tunnel_dev Nicolas Dichtel
2014-04-15 4:04 ` David Miller [this message]
2014-04-15 7:57 ` Nicolas Dichtel
2014-04-15 18:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415.000404.2110427476393772943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=xeb@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).