From: David Miller <davem@davemloft.net>
To: zhen-hual@hp.com
Cc: sathya.perla@emulex.com, subbu.seetharaman@emulex.com,
ajit.khaparde@emulex.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet
Date: Tue, 15 Apr 2014 15:09:50 -0400 (EDT) [thread overview]
Message-ID: <20140415.150950.2105729446204659132.davem@davemloft.net> (raw)
In-Reply-To: <1397544352-28841-1-git-send-email-zhen-hual@hp.com>
From: "Li, Zhen-Hua" <zhen-hual@hp.com>
Date: Tue, 15 Apr 2014 14:45:52 +0800
> From: "Li, Zhen-Hua" <zhen-hual@hp.com>
>
> In benet driver, netif_device_detach and netif_device_attach should be
> called between rtnl_lock and rtnl_unlock.
>
> Signed-off-by: Li, Zhen-Hua <zhen-hual@hp.com>
This absolutely does not look like a driver specific issue, therefore
I do not want you to make such locking context adjustments only in
your driver.
Do it somewhere generic so that every driver gets the fix, not just
your driver.
next prev parent reply other threads:[~2014-04-15 19:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 6:45 [PATCH 1/1] driver/net: add missing rtnl lock/unlock for benet Li, Zhen-Hua
2014-04-15 8:07 ` Sathya Perla
2014-04-15 9:02 ` Li, ZhenHua
2014-04-15 11:57 ` Sathya Perla
2014-04-15 12:59 ` Li, Zhen-Hua
2014-04-15 19:09 ` David Miller [this message]
2014-04-16 6:30 ` Li, ZhenHua
2014-04-16 7:09 ` Li, ZhenHua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140415.150950.2105729446204659132.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ajit.khaparde@emulex.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
--cc=zhen-hual@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).