From: Dan Carpenter <dan.carpenter@oracle.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Stable <stable@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH 2/2 V2] staging: r8188eu: Fix case where ethtype was never obtained and always be checked against 0
Date: Thu, 17 Apr 2014 02:41:07 +0300 [thread overview]
Message-ID: <20140416234107.GT26890@mwanda> (raw)
In-Reply-To: <1397677774-20283-2-git-send-email-Larry.Finger@lwfinger.net>
On Wed, Apr 16, 2014 at 02:49:34PM -0500, Larry Finger wrote:
> if (auth_alg == 2) {
> + /* get ether_type */
> + ptr = ptr + pfhdr->attrib.hdrlen + LLC_HEADER_SIZE;
> + memcpy(ðer_type, ptr, 2);
> + ether_type = ntohs((unsigned short)ether_type);
The incorrect cast here introduces a new sparse warning.
https://lwn.net/Articles/205624/
regards,
dan carpenter
prev parent reply other threads:[~2014-04-16 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 19:49 [PATCH 1/2 V2] staging: r8712u: Fix case where ethtype was never obtained and always be checked against 0 Larry Finger
2014-04-16 19:49 ` [PATCH 2/2 V2] staging: r8188eu: " Larry Finger
2014-04-16 23:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416234107.GT26890@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).