From: David Miller <davem@davemloft.net>
To: nasa4836@gmail.com
Cc: nhorman@tuxdriver.com, tj@kernel.org, daniel.wagner@bmw-carit.de,
gaofeng@cn.fujitsu.com, stephen@networkplumber.org,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netprio_cgroup: explicitly init the early_init field
Date: Tue, 22 Apr 2014 12:13:15 -0400 (EDT) [thread overview]
Message-ID: <20140422.121315.929124038777369470.davem@davemloft.net> (raw)
In-Reply-To: <CAHz2CGWfwx+SOTurpW2fO4LsB08tp2ANw+k6aa6bGL=15LNScQ@mail.gmail.com>
From: Jianyu Zhan <nasa4836@gmail.com>
Date: Tue, 22 Apr 2014 19:25:41 +0800
> I don't think that the value of one field(early_init) has a so subtle
> restrition on the another field(css_alloc) is a good thing, but since
> it is there, docment it should be needed.
This is not a reasonable change.
We depend upon implicit initialization to zero all over the kernel,
and adding explicit assignments hurts rather then helps.
prev parent reply other threads:[~2014-04-22 16:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 5:32 [PATCH] netprio_cgroup: explicitly init the early_init field Jianyu Zhan
2014-04-22 11:19 ` Neil Horman
2014-04-22 11:25 ` Jianyu Zhan
2014-04-22 16:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422.121315.929124038777369470.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=daniel.wagner@bmw-carit.de \
--cc=gaofeng@cn.fujitsu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=nasa4836@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=stephen@networkplumber.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).