From: Greg Rose <gregory.v.rose@intel.com>
To: David Gibson <dgibson@redhat.com>
Cc: David Miller <davem@davemloft.net>, <ben@decadent.org.uk>,
<netdev@vger.kernel.org>, <benve@cisco.com>, <ssujith@cisco.com>,
<govindarajulu90@gmail.com>, <neepatel@cisco.com>,
<nistrive@cisco.com>
Subject: Re: RFC: rtnetlink problems with Cisco enic and VFs
Date: Tue, 22 Apr 2014 17:04:38 -0700 [thread overview]
Message-ID: <20140422170438.00006b45@unknown> (raw)
In-Reply-To: <20140423092606.c73425b64d127b8f94469fcb@redhat.com>
On Wed, 23 Apr 2014 09:26:06 +1000
David Gibson <dgibson@redhat.com> wrote:
> On Tue, 22 Apr 2014 14:12:00 -0400 (EDT)
> David Miller <davem@davemloft.net> wrote:
>
> > From: Ben Hutchings <ben@decadent.org.uk>
> > Date: Tue, 22 Apr 2014 19:03:19 +0100
> >
> > > On Tue, 2014-04-22 at 14:14 +1000, David Gibson wrote:
> > >> I believe I've found a problem with netlink handling which can be
> > >> triggered on Cisco enic devices with a large number (30-40) of
> > >> virtual functions. I believe this is the cause of a real
> > >> customer problem we've seen.
> > >>
> > >> * When requesting a list of interfaces with RTM_GETLINK, enic
> > >> devices (and currently, _only_ enic devices) report IFLA_VF_PORTS
> > >> information
> > >>
> > >> * IFLA_VF_PORTS information has at least 90 bytes ber virtual
> > >> function
> > >>
> > >> * Unlike IFLA_VFINFO_LIST, the ports information is always
> > >> reported, regardless of the setting of the IFLA_EXT_MASK
> > >> parameter
> > > [...]
> > >
> > > So I think you should make reporting of IFLA_VF_PORTS dependent
> > > on the same flag as IFLA_VFINFO_LIST.
> >
> > I think that's what we'll have to do.
>
> Ok, makes logical sense.
>
> But does anyone know what tools make use of the IFLA_VF_PORTS
> information? Do they set the IFLA_EXT_MASK already?
>
So far as I know only the IP route tool 'ip link' sets that. In fact,
that's the reason I had to add it some number of years and months ago
was because there were tools that didn't expect to get all the
additional VF info and those tools were getting borked by all the
additional goo sent up for VFs.
Beyond that who knows what anyone's been up to with other tools in
other places?
- Greg
next prev parent reply other threads:[~2014-04-23 0:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 4:14 RFC: rtnetlink problems with Cisco enic and VFs David Gibson
2014-04-22 4:17 ` David Gibson
2014-04-22 18:03 ` Ben Hutchings
2014-04-22 18:12 ` David Miller
2014-04-22 23:26 ` David Gibson
2014-04-23 0:04 ` Greg Rose [this message]
2014-04-23 1:12 ` David Gibson
2014-04-23 1:16 ` David Miller
2014-04-23 2:33 ` Christian Benvenuti (benve)
2014-04-23 4:15 ` David Gibson
2014-04-23 0:59 ` David Miller
2014-04-22 19:14 ` Christian Benvenuti (benve)
2014-04-22 23:24 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422170438.00006b45@unknown \
--to=gregory.v.rose@intel.com \
--cc=ben@decadent.org.uk \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=dgibson@redhat.com \
--cc=govindarajulu90@gmail.com \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=nistrive@cisco.com \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).