Re: [PATCH v2] net: cadence: Add architecture dependencies

[Jean Delvare <jdelvare@suse.de>]

Hi Michal,

On Wed, 23 Apr 2014 11:35:55 +0200, Michal Simek wrote:
> On 04/23/2014 09:40 AM, Jean Delvare wrote:
> > Thanks for the information. I will send a patch adding MICROBLAZE to
> > the dependencies. Out of curiosity, is there any way I could have found
> > out by myself?
> 
> Microblaze doesn't need to be only one. I am not sure if there is
> any AXI bridge for openrisc.

You lost me here again :-(

> IMHO you should just add COMPILE_TEST and do not try to extend that
> list of dependencies.

COMPILE_TEST is already present, I can't add it twice ;-) But
COMPILE_TEST isn't supposed to be used when the architecture /
platform / system is actually expected to possibly need the driver in
question. If the list of possible hardware dependencies isn't well
known, or is too complex to express, or too difficult to maintain, then
we have to either make it broader, or even drop it.

Originally I wanted to hide the Cadence drivers from X86 kernel
configuration. If there's still a way to achieve that, let's do it. If
not, we can leave the hardware dependency for ARM_AT91_ETHER and drop
the one for MACB (and subsequently NET_CADENCE.) That's still better
than nothing.

Please let me know how you want to proceed.

Thanks,
-- 
Jean Delvare
SUSE L3 Support