From: Florian Westphal <fw@strlen.de>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: netdev <netdev@vger.kernel.org>, Vasiliy Kulikov <segoon@openwall.com>
Subject: Re: [RFC][PATCH] IP: Make ping sockets optional
Date: Wed, 23 Apr 2014 17:30:18 +0200 [thread overview]
Message-ID: <20140423153018.GA13717@breakpoint.cc> (raw)
In-Reply-To: <1398266428.7767.140.camel@deadeye.wl.decadent.org.uk>
Ben Hutchings <ben@decadent.org.uk> wrote:
> ICMP ping sockets currently require a new ping binary and are only
> available after setting a sysctl. The code adds about 10K to the
> (uncompressed) size of the kernel. Make this optional and disable
> it by default.
>
> This is compile-tested only; I'd just like to see whether people think
> this is worth doing.
Either this feature needs to be ripped out now or it has to be kept.
I do not think the middle-ground you're proposing will work:
If userspace cannot safely assume facility is available, binaries
need to be setuid to implement fallback, and when you go down that
road you've gained nothing and might as well not support ping sockets
at all.
next prev parent reply other threads:[~2014-04-23 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 15:20 [RFC][PATCH] IP: Make ping sockets optional Ben Hutchings
2014-04-23 15:30 ` Florian Westphal [this message]
2014-04-23 15:55 ` Ben Hutchings
2014-04-23 16:27 ` Florian Westphal
2014-04-24 15:17 ` Hannes Frederic Sowa
2014-04-24 16:02 ` Ben Hutchings
2014-04-24 16:37 ` Hannes Frederic Sowa
2014-04-25 10:37 ` Lorenzo Colitti
2014-04-25 21:18 ` Hannes Frederic Sowa
2014-04-26 3:02 ` Lorenzo Colitti
2014-04-25 21:43 ` Ben Hutchings
2014-04-23 16:05 ` David Laight
2014-04-24 15:59 ` Lorenzo Colitti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140423153018.GA13717@breakpoint.cc \
--to=fw@strlen.de \
--cc=ben@decadent.org.uk \
--cc=netdev@vger.kernel.org \
--cc=segoon@openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).