From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: carolyn.wyborny@intel.com, netdev@vger.kernel.org,
gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 07/13] igb: Cleanups to fix line length warnings
Date: Thu, 24 Apr 2014 12:40:03 -0400 (EDT) [thread overview]
Message-ID: <20140424.124003.1781449604554546212.davem@davemloft.net> (raw)
In-Reply-To: <1398335460-4283-8-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 24 Apr 2014 03:30:54 -0700
> From: Carolyn Wyborny <carolyn.wyborny@intel.com>
>
> This patch fixes WARNING:LONG_LINE found with checkpatch check.
>
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@intel.com>
> Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 13 ++++++++-----
> drivers/net/ethernet/intel/igb/igb_main.c | 8 +++++---
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 561df67..6aed00f 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -1129,8 +1129,10 @@ static struct igb_reg_test reg_test_82576[] = {
> { E1000_RDBAH(4), 0x40, 12, PATTERN_TEST, 0xFFFFFFFF, 0xFFFFFFFF },
> { E1000_RDLEN(4), 0x40, 12, PATTERN_TEST, 0x000FFFF0, 0x000FFFFF },
> /* Enable all RX queues before testing. */
> - { E1000_RXDCTL(0), 0x100, 4, WRITE_NO_TEST, 0, E1000_RXDCTL_QUEUE_ENABLE },
> - { E1000_RXDCTL(4), 0x40, 12, WRITE_NO_TEST, 0, E1000_RXDCTL_QUEUE_ENABLE },
> + { E1000_RXDCTL(0), 0x100, 4, WRITE_NO_TEST, 0,
> + E1000_RXDCTL_QUEUE_ENABLE },
The second line should start at the same column as E1000_RXDCTL(0) on the first
line, rather than tabbed all the way to outer-space.
next prev parent reply other threads:[~2014-04-24 16:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:30 [net-next 00/13][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-04-24 10:30 ` [net-next 01/13] igb: Cleanups to fix pointer location error Jeff Kirsher
2014-04-24 10:30 ` [net-next 02/13] igb: Cleanups to fix for trailing statement Jeff Kirsher
2014-04-24 10:30 ` [net-next 03/13] igb: Cleanups to change comment style on license headers Jeff Kirsher
2014-04-24 10:30 ` [net-next 04/13] igb: Cleanups to fix assignment in if error Jeff Kirsher
2014-04-24 10:30 ` [net-next 05/13] igb: Cleanups to fix missing break in switch statements Jeff Kirsher
2014-04-24 10:30 ` [net-next 06/13] igb: Cleanups to remove return parentheses Jeff Kirsher
2014-04-24 10:30 ` [net-next 07/13] igb: Cleanups to fix line length warnings Jeff Kirsher
2014-04-24 16:40 ` David Miller [this message]
2014-04-24 17:02 ` Wyborny, Carolyn
2014-04-24 10:30 ` [net-next 08/13] igb: Cleanups to fix msleep warnings Jeff Kirsher
2014-04-24 10:30 ` [net-next 09/13] igb: Cleanups to fix static initialization Jeff Kirsher
2014-04-24 10:30 ` [net-next 10/13] igb: Cleanups to replace deprecated DEFINE_PCI_DEVICE_TABLE Jeff Kirsher
2014-04-24 10:30 ` [net-next 11/13] igb: Cleanups to remove unneeded extern declaration Jeff Kirsher
2014-04-24 10:30 ` [net-next 12/13] igb: Replace 1/0 return values with true/false Jeff Kirsher
2014-04-24 10:31 ` [net-next 13/13] igb: Change memcpy to struct assignment Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424.124003.1781449604554546212.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=carolyn.wyborny@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).