From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: dborkman@redhat.com, netdev@vger.kernel.org, joe@perches.com
Subject: Re: [PATCH][net-next] tcp: remove the duplicate prefixes in the logging message
Date: Thu, 24 Apr 2014 13:26:01 -0400 (EDT) [thread overview]
Message-ID: <20140424.132601.1353360035894164439.davem@davemloft.net> (raw)
In-Reply-To: <CAJFZqHxg9YSmHWb9DgmdtO01vVz3vN86DaCNdswRtZviemh3mQ@mail.gmail.com>
From: Li RongQing <roy.qing.li@gmail.com>
Date: Wed, 23 Apr 2014 21:32:43 +0800
> On Wed, Apr 23, 2014 at 5:35 PM, Daniel Borkmann <dborkman@redhat.com> wrote:
>> On 04/23/2014 11:28 AM, roy.qing.li@gmail.com wrote:
>>>
>>> From: Li RongQing <roy.qing.li@gmail.com>
>>>
>>> The current message is:
>>> TCP: TCP: Possible SYN flooding on port 80. Sending cookies. ...
>>>
>>> The cause is that pr_info will implicitly print the pr_fmt string, which
>>> is standard
>>> prefix, and explicitly print the "proto" which is "TCP:" too
>>>
>>> it is unsuitable to not print proto, since proto maybe TCPv6, so use
>>> printk directly.
>>
>>
>> Can't you just leave the pr_info() instead, and reword that into something
>> like:
>>
>> "Possible %s SYN flooding[...]", proto
> To ipv4:
>
> TCP: Possible TCP SYN flooding on port 80. Sending cookies. ...
>
> To ipv6:
>
> TCP: Possible TCPv6 SYN flooding on port 80. Sending cookies. ...
>
>
> I think there are two "TCP" still, and it is duplicate;
Just kill the proto string altogether, I don't think it doesn't adds
anything.
next prev parent reply other threads:[~2014-04-24 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 9:28 [PATCH][net-next] tcp: remove the duplicate prefixes in the logging message roy.qing.li
2014-04-23 9:35 ` Daniel Borkmann
2014-04-23 13:32 ` Li RongQing
2014-04-24 17:26 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-04-21 13:17 roy.qing.li
2014-04-22 0:04 ` Li RongQing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424.132601.1353360035894164439.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).