From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][net-next] tcp: remove the duplicate prefixes in the logging message Date: Thu, 24 Apr 2014 13:26:01 -0400 (EDT) Message-ID: <20140424.132601.1353360035894164439.davem@davemloft.net> References: <1398245335-18780-1-git-send-email-roy.qing.li@gmail.com> <5357897D.8060809@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dborkman@redhat.com, netdev@vger.kernel.org, joe@perches.com To: roy.qing.li@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:32857 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757496AbaDXR0D (ORCPT ); Thu, 24 Apr 2014 13:26:03 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Li RongQing Date: Wed, 23 Apr 2014 21:32:43 +0800 > On Wed, Apr 23, 2014 at 5:35 PM, Daniel Borkmann wrote: >> On 04/23/2014 11:28 AM, roy.qing.li@gmail.com wrote: >>> >>> From: Li RongQing >>> >>> The current message is: >>> TCP: TCP: Possible SYN flooding on port 80. Sending cookies. ... >>> >>> The cause is that pr_info will implicitly print the pr_fmt string, which >>> is standard >>> prefix, and explicitly print the "proto" which is "TCP:" too >>> >>> it is unsuitable to not print proto, since proto maybe TCPv6, so use >>> printk directly. >> >> >> Can't you just leave the pr_info() instead, and reword that into something >> like: >> >> "Possible %s SYN flooding[...]", proto > To ipv4: > > TCP: Possible TCP SYN flooding on port 80. Sending cookies. ... > > To ipv6: > > TCP: Possible TCPv6 SYN flooding on port 80. Sending cookies. ... > > > I think there are two "TCP" still, and it is duplicate; Just kill the proto string altogether, I don't think it doesn't adds anything.