From: David Miller <davem@davemloft.net>
To: david@gibson.dropbear.id.au
Cc: netdev@vger.kernel.org, ssujith@cisco.com, neepatel@cisco.com,
benve@cisco.com, ben@decadent.org.uk, govindarajulu90@gmail.com,
gregory.v.rose@intel.com
Subject: Re: [0/2] Fix problems with with IFLA_VF_PORTS (v2)
Date: Thu, 24 Apr 2014 13:53:23 -0400 (EDT) [thread overview]
Message-ID: <20140424.135323.2147922052612934860.davem@davemloft.net> (raw)
In-Reply-To: <1398298956-13084-1-git-send-email-david@gibson.dropbear.id.au>
From: David Gibson <david@gibson.dropbear.id.au>
Date: Thu, 24 Apr 2014 10:22:34 +1000
> I've had a customer encounter a problem with getifaddrs(3) freezing up
> on a system with a Cisco enic device.
>
> I've discovered that the problem is caused by an enic device with a
> large number of SR-IOV virtual functions overflowing the normal sized
> packet buffer for netlink, leading to interfaces not being reported
> from an RTM_GETLINK request.
>
> The first patch here just makes the problem easier to locate if it
> occurs again in a different way, by adding a WARN_ON() when we run out
> of room in a netlink packet in this manner.
>
> The second patch actually fixes the problem, by only reporting
> IFLA_VF_PORTS information when the RTEXT_FILTER_VF flag is specified.
>
> v2: Corrected some CodingStyle problems
Series applied to 'net' and queued up for -stable.
Thanks!
prev parent reply other threads:[~2014-04-24 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 0:22 [0/2] Fix problems with with IFLA_VF_PORTS (v2) David Gibson
2014-04-24 0:22 ` [PATCH 1/2] rtnetlink: Warn when interface's information won't fit in our packet David Gibson
2014-04-24 15:49 ` Jiri Pirko
2014-04-24 0:22 ` [PATCH 2/2] rtnetlink: Only supply IFLA_VF_PORTS information when RTEXT_FILTER_VF is set David Gibson
2014-04-24 15:51 ` Jiri Pirko
2014-04-24 17:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424.135323.2147922052612934860.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ben@decadent.org.uk \
--cc=benve@cisco.com \
--cc=david@gibson.dropbear.id.au \
--cc=govindarajulu90@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=neepatel@cisco.com \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).