From: yamamoto@valinux.co.jp (YAMAMOTO Takashi)
To: horms@verge.net.au
Cc: dev@openvswitch.org, netdev@vger.kernel.org, jesse@nicira.com,
pshelar@nicira.com, rkerur@gmail.com
Subject: Re: [ovs-dev] [PATCH v2.56] datapath: Add basic MPLS support to kernel
Date: Thu, 24 Apr 2014 17:57:29 +0900 (JST) [thread overview]
Message-ID: <20140424085729.CBE6671E58@kuma.localdomain> (raw)
In-Reply-To: Your message of "Tue, 1 Apr 2014 12:46:21 +0900" <1396323981-20700-2-git-send-email-horms@verge.net.au>
hi,
> + * Due to the sample action there may be multiple possible eth types.
> + * In order to correctly validate actions all possible types are tracked
> + * and verified. This is done using struct eth_types.
is there any real-world use cases of these actions inside a sample?
otherwise, how about just rejecting such combinations?
it doesn't seem to worth the code complexity to me.
(sorry if it has been already discussed. it's the first time for me
to seriously read this long-lived patch.)
YAMAMOTO Takashi
next prev parent reply other threads:[~2014-04-24 8:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 3:46 [PATCH v2.56] datapath: Add basic MPLS support to kernel Simon Horman
[not found] ` <1396323981-20700-1-git-send-email-horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-01 3:46 ` Simon Horman
2014-04-24 8:57 ` YAMAMOTO Takashi [this message]
2014-04-24 23:24 ` [ovs-dev] " Simon Horman
[not found] ` <20140424232441.GA6282-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-25 8:06 ` YAMAMOTO Takashi
[not found] ` <20140425080639.DDFA371E74-0CV7wKnmZOB82hYKe6nXyg@public.gmane.org>
2014-04-25 19:57 ` Jesse Gross
[not found] ` <CAEP_g=8y=jXukP=a2xyk4XMTrBLYWPQOgbTO_h8LE_mVMB9tFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-28 2:04 ` YAMAMOTO Takashi
2014-04-28 7:00 ` Simon Horman
[not found] ` <20140428070012.GB21494-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-28 21:37 ` Jesse Gross
2014-04-29 0:13 ` [ovs-dev] " Simon Horman
2014-04-29 18:41 ` Jesse Gross
2014-04-30 5:58 ` Simon Horman
[not found] ` <20140430055807.GA8246-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-04-30 22:56 ` Jesse Gross
2014-05-01 8:54 ` [ovs-dev] " Simon Horman
[not found] ` <20140501085442.GA20410-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2014-05-01 16:45 ` Jesse Gross
[not found] ` <CAEP_g=-rBXBJ4-CMRuPTxGnrqT-0PNMttvA5_HdugeM5to5Cew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-11 2:49 ` Simon Horman
2014-04-09 23:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424085729.CBE6671E58@kuma.localdomain \
--to=yamamoto@valinux.co.jp \
--cc=dev@openvswitch.org \
--cc=horms@verge.net.au \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=rkerur@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox