From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>,
David Miller <davem@davemloft.net>,
Daniel Borkmann <dborkman@redhat.com>,
Network Development <netdev@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: [PATCH net] net: filter: initialize A and X registers
Date: Thu, 24 Apr 2014 09:07:12 +0200 [thread overview]
Message-ID: <20140424090712.489f9bc5@mschwide> (raw)
In-Reply-To: <1398308109.29914.61.camel@edumazet-glaptop2.roam.corp.google.com>
On Wed, 23 Apr 2014 19:55:09 -0700
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Wed, 2014-04-23 at 15:19 -0700, Alexei Starovoitov wrote:
>
> > yes, x86 jit is smart to deal around this problem in an efficient way.
> > sparc/arm jits copy pasted the idea correctly.
>
> Well... not really smart, but sufficient enough (even if I am sure we
> probably have some bugs)
>
> > but s390 jit seems to have a bug, since it's not clearing A
> > when 1st insn is BPF_S_LDX_B_MSH
>
> Sure, JIT is hard and quite risky (You forgot to CC Heiko & Martin, they
> probably can send the needed patch)
That should be a one-line patch which removes the BPF_S_LDX_B_MSH opcode
from the switch statement in bpf_jit_noleaks.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2014-04-24 7:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 3:18 [PATCH net] net: filter: initialize A and X registers Alexei Starovoitov
2014-04-23 3:57 ` David Miller
2014-04-23 4:59 ` Alexei Starovoitov
2014-04-23 7:02 ` Daniel Borkmann
2014-04-23 16:52 ` David Miller
2014-04-23 17:20 ` Daniel Borkmann
2014-04-23 16:50 ` David Miller
2014-04-23 20:38 ` Alexei Starovoitov
2014-04-23 21:39 ` Eric Dumazet
2014-04-23 22:19 ` Alexei Starovoitov
2014-04-24 2:55 ` Eric Dumazet
2014-04-24 3:22 ` Alexei Starovoitov
2014-04-25 8:23 ` Daniel Borkmann
2014-04-24 7:07 ` Martin Schwidefsky [this message]
2014-04-23 5:13 ` Eric Dumazet
2014-04-23 11:45 ` Daniel Borkmann
2014-04-23 13:39 ` Eric Dumazet
2014-04-23 21:07 ` David Miller
2014-04-23 16:51 ` David Miller
2014-04-23 17:10 ` Daniel Borkmann
2014-04-23 17:14 ` Eric Dumazet
2014-04-24 17:24 ` David Miller
2014-04-24 18:11 ` Eric Dumazet
2014-04-24 22:18 ` Daniel Borkmann
2014-04-23 7:53 ` Daniel Borkmann
2014-04-23 16:13 ` Alexei Starovoitov
2014-04-23 19:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424090712.489f9bc5@mschwide \
--to=schwidefsky@de.ibm.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=heiko.carstens@de.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).