From: Stephen Hemminger <stephen@networkplumber.org>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com,
stable@kernel.org
Subject: Re: [PATCH net-next 1/1] hyperv: Properly handle checksum offload
Date: Fri, 25 Apr 2014 17:43:22 -0700 [thread overview]
Message-ID: <20140425174322.589ed9f1@samsung-9> (raw)
In-Reply-To: <1398451514-25593-1-git-send-email-kys@microsoft.com>
On Fri, 25 Apr 2014 11:45:14 -0700
"K. Y. Srinivasan" <kys@microsoft.com> wrote:
> @@ -474,6 +477,9 @@ static int netvsc_start_xmit(struct sk_buff *skb, struct net_device *net)
> csum_info = (struct ndis_tcp_ip_checksum_info *)((void *)ppi +
> ppi->ppi_offset);
>
> + ip_hdr(skb)->check = 0;
> + csum_info->transmit.ip_header_checksum = 1;
> +
> if (net_trans_info & (INFO_IPV4 << 16))
> csum_info->transmit.is_ipv4 = 1;
> else
Linux doesn't need or want IP checksum offload.
It will not have any performance gain.
next prev parent reply other threads:[~2014-04-26 0:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 18:45 [PATCH net-next 1/1] hyperv: Properly handle checksum offload K. Y. Srinivasan
2014-04-26 0:43 ` Stephen Hemminger [this message]
2014-04-26 1:15 ` Eric Dumazet
2014-04-26 2:24 ` KY Srinivasan
2014-04-26 2:40 ` KY Srinivasan
2014-04-26 2:23 ` KY Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425174322.589ed9f1@samsung-9 \
--to=stephen@networkplumber.org \
--cc=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@linuxdriverproject.org \
--cc=jasowang@redhat.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox