From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ipv6: Set flow label to skb_hash on transmit
Date: Sun, 27 Apr 2014 23:39:13 -0400 (EDT) [thread overview]
Message-ID: <20140427.233913.1970424291703869574.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.2.02.1404261553180.15772@tomh.mtv.corp.google.com>
From: Tom Herbert <therbert@google.com>
Date: Sat, 26 Apr 2014 16:00:30 -0700 (PDT)
> - ip6_flow_hdr(ipv6h, INET_ECN_encapsulate(0, dsfield), fl6->flowlabel);
> + ip6_flow_hdr(ipv6h, INET_ECN_encapsulate(0, dsfield,
> + ip6_make_flowlabel(net, skb, fl6->flowlabel)));
This doesn't compile on the planet on which I live.
net/ipv6/ip6_tunnel.c: In function ‘ip6_tnl_xmit2’:
net/ipv6/ip6_tunnel.c:1049:8: error: too many arguments to function ‘INET_ECN_encapsulate’
ip6_make_flowlabel(net, skb, fl6->flowlabel)));
^
In file included from include/net/ip_tunnels.h:11:0,
from net/ipv6/ip6_tunnel.c:50:
include/net/inet_ecn.h:43:20: note: declared here
static inline __u8 INET_ECN_encapsulate(__u8 outer, __u8 inner)
^
net/ipv6/ip6_tunnel.c:1049:8: error: too few arguments to function ‘ip6_flow_hdr’
ip6_make_flowlabel(net, skb, fl6->flowlabel)));
^
In file included from include/net/inetpeer.h:15:0,
from include/net/route.h:28,
from include/net/ip.h:31,
from net/ipv6/ip6_tunnel.c:49:
include/net/ipv6.h:684:20: note: declared here
static inline void ip6_flow_hdr(struct ipv6hdr *hdr, unsigned int tclass,
^
make[1]: *** [net/ipv6/ip6_tunnel.o] Error 1
make: *** [net/ipv6/ip6_tunnel.o] Error 2
next prev parent reply other threads:[~2014-04-28 3:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-26 23:00 [PATCH 2/2] ipv6: Set flow label to skb_hash on transmit Tom Herbert
2014-04-26 23:40 ` Eric Dumazet
2014-04-27 0:06 ` Tom Herbert
2014-04-28 3:39 ` David Miller [this message]
2014-04-28 18:12 ` Florent Fourcot
2014-04-28 18:30 ` Florent Fourcot
2014-04-28 19:29 ` Tom Herbert
2014-04-28 19:37 ` Florent Fourcot
2014-04-28 20:19 ` Tom Herbert
2014-04-28 20:49 ` Florent Fourcot
2014-04-28 21:13 ` Tom Herbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140427.233913.1970424291703869574.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).