From: David Miller <davem@davemloft.net>
To: erik.hugne@ericsson.com
Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org,
tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net-next] tipc: fix out of bounds indexing
Date: Mon, 28 Apr 2014 14:49:26 -0400 (EDT) [thread overview]
Message-ID: <20140428.144926.436860974988702953.davem@davemloft.net> (raw)
In-Reply-To: <1398666009-1334-1-git-send-email-erik.hugne@ericsson.com>
From: <erik.hugne@ericsson.com>
Date: Mon, 28 Apr 2014 08:20:09 +0200
> From: Erik Hugne <erik.hugne@ericsson.com>
>
> Commit 78acb1f9b898e85fa2c1e28e700b54b66b288e8d ("tipc: add
> ioctl to fetch link names") introduced a buffer overflow bug where
> specially crafted ioctl requests could cause out-of-bounds indexing
> of the node->links array. This was caused by an incorrect check vs
> MAX_BEARERS, and the static code checker complaint is:
> net/tipc/node.c:459 tipc_node_get_linkname() error: buffer overflow 'node->links' 2 <= 2
>
> Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos. Get
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
prev parent reply other threads:[~2014-04-28 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 6:20 [PATCH net-next] tipc: fix out of bounds indexing erik.hugne
2014-04-28 18:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428.144926.436860974988702953.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).