From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net phy: Check for aneg completion before setting state to PHY_RUNNING Date: Mon, 28 Apr 2014 16:17:29 -0400 (EDT) Message-ID: <20140428.161729.1716684656113345953.davem@davemloft.net> References: <53587C7F.2000808@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, netdev@vger.kernel.org To: kumaran.4353@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:45683 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751690AbaD1URb (ORCPT ); Mon, 28 Apr 2014 16:17:31 -0400 In-Reply-To: <53587C7F.2000808@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Balakumaran Kannan Date: Thu, 24 Apr 2014 08:22:47 +0530 > phy_state_machine should check whether auto-negotiatin is completed > before changing phydev->state from PHY_NOLINK to PHY_RUNNING. If > auto-negotiation is not completed phydev->state should be set to > PHY_AN. > > Signed-off-by: Balakumaran Kannan Florian can you please review this at your earliest possible convenience? Thanks!