From: David Miller <davem@davemloft.net>
To: tobias.klauser@gmail.com
Cc: vbridgers2013@gmail.com, netdev@vger.kernel.org,
nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH net v2] Altera TSE: Fix DMA secriptor length initialization
Date: Wed, 30 Apr 2014 16:14:33 -0400 (EDT) [thread overview]
Message-ID: <20140430.161433.1833281012752521346.davem@davemloft.net> (raw)
In-Reply-To: <1398720181-19450-1-git-send-email-tklauser@distanz.ch>
From: Tobias Klauser <tobias.klauser@gmail.com>
Date: Mon, 28 Apr 2014 23:23:01 +0200
> sgdma_descrip is a function name as well as the name of a struct. In
> sgdma_initialize(), we should initialize the descriptor length field
> with the actual length of a descriptor not with the size of the
> function. In order to prevent such things from happening in the future,
> rename the function to sgdma_setup_descrip().
>
> Found by sparse which yields the following warning:
>
> drivers/net/ethernet/altera/altera_sgdma.c:74:30: warning: expression using sizeof on a function
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
prev parent reply other threads:[~2014-04-30 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 21:23 [PATCH net v2] Altera TSE: Fix DMA secriptor length initialization Tobias Klauser
2014-04-28 22:37 ` Vince Bridgers
2014-04-29 7:05 ` Tobias Klauser
2014-04-29 17:52 ` David Miller
2014-04-30 20:14 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430.161433.1833281012752521346.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=tobias.klauser@gmail.com \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).