From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: netdev@vger.kernel.org,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH for v3.15] net: mvmdio: Check for a valid interrupt instead of an error
Date: Wed, 30 Apr 2014 13:21:01 -0300 [thread overview]
Message-ID: <20140430162101.GA18300@arch.cereza> (raw)
In-Reply-To: <5360FA35.7070209@gmail.com>
On Apr 30, Sebastian Hesselbarth wrote:
> >
> >Yes, I agree. Did another patch for that, but haven't send it yet.
> >AFAICS, mvebu platforms will never hit the deferred case as the irqchip
> >is the first driver registered (as per drivers/Makefile).
> >
> >Not that we should count on that :)
>
> It doesn't hit it _now_ because of the above. I read about proper
> platform_device for early devices here and there over and over
> again, so I guess some day it may become an issue.
>
> As we know about the potential -EPROBE_DEFER now, I suggest to
> deal with it now, too.
>
> Can you resend this as v2 with the other patch you mentioned
> squashed in?
>
Oh! I've just remembered why I didn't send the EPROBE_DEFER patch in the first
place. The mvneta driver connects to the phy at open()-time, in a function
called "mvneta_mdio_probe()". This name confused me to think the mdio was
really probed at open()-time.
I guess it was very late at night when I came to such conclusion :)
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-04-30 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 19:49 [PATCH for v3.15] net: mvmdio: Check for a valid interrupt instead of an error Ezequiel Garcia
2014-04-29 21:37 ` Sebastian Hesselbarth
2014-04-30 11:42 ` Ezequiel Garcia
2014-04-30 13:27 ` Sebastian Hesselbarth
2014-04-30 16:03 ` Ezequiel Garcia
2014-04-30 16:21 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140430162101.GA18300@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).