From: David Miller <davem@davemloft.net>
To: nhorman@tuxdriver.com
Cc: netdev@vger.kernel.org, cooldavid@cooldavid.org
Subject: Re: [PATCH] jme: Fix DMA unmap warning
Date: Wed, 07 May 2014 15:56:13 -0400 (EDT) [thread overview]
Message-ID: <20140507.155613.630399521517455317.davem@davemloft.net> (raw)
In-Reply-To: <1399315907-27148-1-git-send-email-nhorman@tuxdriver.com>
From: Neil Horman <nhorman@tuxdriver.com>
Date: Mon, 5 May 2014 14:51:47 -0400
> The jme driver forgot to check the return status from pci_map_page in its tx
> path, causing a dma api warning on unmap. Easy fix, just do the check and
> augment the tx path to tell the stack that the driver is busy so we re-queue the
> frame.
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Applied thanks Neil.
Probably we should eventually come up with a perhaps more suitable recovery
scheme in the generic netdev queuing layer for these situations.
If a mapping fails, usually it's because of resource exhaustion and that's
a "wait and try again" type situation in hoping that whatever releases
are keeping the allocation from happening will get released.
But that's not exactly what we do right now when NETDEV_TX_BUSY is
signalled. We'll just loop over and over in the TX software interrupt
handler for the qdisc.
Perhaps an hrtimer or similar would be more appropriate.
next prev parent reply other threads:[~2014-05-07 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 18:51 [PATCH] jme: Fix DMA unmap warning Neil Horman
2014-05-06 20:25 ` Govindarajulu Varadarajan
2014-05-06 20:50 ` Neil Horman
2014-05-06 20:53 ` David Miller
2014-05-06 21:04 ` Govindarajulu Varadarajan
2014-05-06 21:10 ` David Miller
2014-05-07 19:56 ` David Miller [this message]
2014-05-07 20:33 ` Neil Horman
2014-05-07 20:44 ` David Miller
2014-05-07 21:54 ` Neil Horman
2014-05-08 9:02 ` David Laight
2014-05-08 11:00 ` Neil Horman
2014-05-08 11:16 ` David Laight
2014-05-08 17:24 ` David Miller
2014-05-08 19:29 ` [RFC PATCH] net: Provide linear backoff mechanism for constrained resources at the driver Neil Horman
2014-05-09 8:55 ` David Laight
2014-05-09 11:17 ` Neil Horman
2014-05-09 12:53 ` David Laight
2014-05-09 15:33 ` Neil Horman
2014-05-09 15:46 ` David Laight
2014-05-09 17:02 ` Neil Horman
2014-05-18 16:19 ` Neil Horman
2014-05-21 18:05 ` Cong Wang
2014-05-21 18:49 ` Neil Horman
2014-05-11 12:49 ` [PATCH] jme: Fix DMA unmap warning Ben Hutchings
2014-05-11 13:04 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507.155613.630399521517455317.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cooldavid@cooldavid.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).