netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: _govind@gmx.com
Cc: netdev@vger.kernel.org, ssujith@cisco.com, benve@cisco.com,
	neepatel@cisco.com
Subject: Re: [PATCH net-next] enic: Add support for adaptive interrupt coalescing
Date: Wed, 07 May 2014 17:00:43 -0400 (EDT)	[thread overview]
Message-ID: <20140507.170043.896249393177676627.davem@davemloft.net> (raw)
In-Reply-To: <1399386262-20769-1-git-send-email-_govind@gmx.com>

From: Govindarajulu Varadarajan <_govind@gmx.com>
Date: Tue,  6 May 2014 19:54:22 +0530

> From: Sujith Sankar <ssujith@cisco.com>
> 
> Signed-off-by: Sujith Sankar <ssujith@cisco.com>
> Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>

Please never submit patches except absolutely the most extremely
trivial ones without a real commit log message explaining what
the change does, how it does it, and why you implemented it that
way.

> +enum hrtimer_restart enic_hrtimer_cb(struct hrtimer *timer)
> +{
> +	return HRTIMER_RESTART;
> +}

For example, I have no idea why in the world you need an hrtimer whose
function is a complete NOP if the networking hardware does the
interrupt coalescing for you.

  reply	other threads:[~2014-05-07 21:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 14:24 [PATCH net-next] enic: Add support for adaptive interrupt coalescing Govindarajulu Varadarajan
2014-05-07 21:00 ` David Miller [this message]
2014-05-08  6:13   ` Govindarajulu Varadarajan
2014-05-08 17:03     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507.170043.896249393177676627.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=_govind@gmx.com \
    --cc=benve@cisco.com \
    --cc=neepatel@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssujith@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).