From: David Miller <davem@davemloft.net>
To: popovich_sergei@mail.ru
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] rtnetlink: fix potential NULL pointer dereference
Date: Wed, 07 May 2014 17:04:16 -0400 (EDT) [thread overview]
Message-ID: <20140507.170416.948105227236114740.davem@davemloft.net> (raw)
In-Reply-To: <d525a30e52966da564bc3e4de31c4197a989b2ae.1399388943.git.popovich_sergei@mail.ru>
From: Sergey Popovich <popovich_sergei@mail.ru>
Date: Tue, 6 May 2014 18:13:16 +0300
> Now since commit fbdc1e8c6b79 (rtnetlink: walk through all devs in
> netns safely on link params change) group of network devices can
This is not how you do this, first of all that SHA ID doesn't exist
in any tree other than your's. It's not an existing commit, but
rather one you are adding in this series.
And secondly, and even more importantly, your patch in this series
is adding this new NULL pointer case.
Therefore you should adjust your first patch to handle this properly
since it introduced the possibility of it happening in the first
place.
next prev parent reply other threads:[~2014-05-07 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 15:13 [PATCH 0/3] Fixes to network device group configuration via rtnetlink Sergey Popovich
2014-05-06 15:13 ` [PATCH 1/3] rtnetlink: walk through all devs in netns safely on link params change Sergey Popovich
2014-05-06 15:13 ` [PATCH 2/3] rtnetlink: fix potential NULL pointer dereference Sergey Popovich
2014-05-06 15:26 ` Sergey Popovich
2014-05-07 21:04 ` David Miller [this message]
2014-05-06 15:13 ` [PATCH 3/3] rtnetlink: add IFLA_GROUP to ifla_policy Sergey Popovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507.170416.948105227236114740.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=popovich_sergei@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).