From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/3] rtnetlink: fix potential NULL pointer dereference Date: Wed, 07 May 2014 17:04:16 -0400 (EDT) Message-ID: <20140507.170416.948105227236114740.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: popovich_sergei@mail.ru Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:51920 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751377AbaEGVES (ORCPT ); Wed, 7 May 2014 17:04:18 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Sergey Popovich Date: Tue, 6 May 2014 18:13:16 +0300 > Now since commit fbdc1e8c6b79 (rtnetlink: walk through all devs in > netns safely on link params change) group of network devices can This is not how you do this, first of all that SHA ID doesn't exist in any tree other than your's. It's not an existing commit, but rather one you are adding in this series. And secondly, and even more importantly, your patch in this series is adding this new NULL pointer case. Therefore you should adjust your first patch to handle this properly since it introduced the possibility of it happening in the first place.