From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 1/2] ipv4: move local_port_range out of CONFIG_SYSCTL Date: Wed, 07 May 2014 17:26:41 -0400 (EDT) Message-ID: <20140507.172641.1968628089443229607.davem@davemloft.net> References: <1399399370-7849-1-git-send-email-xiyou.wangcong@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com To: xiyou.wangcong@gmail.com Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:52033 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111AbaEGV0n (ORCPT ); Wed, 7 May 2014 17:26:43 -0400 In-Reply-To: <1399399370-7849-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Cong Wang Date: Tue, 6 May 2014 11:02:49 -0700 > From: Cong Wang > > When CONFIG_SYSCTL is not set, ip_local_port_range should still work, > just that no one can change it. Therefore we should move it out of sysctl_inet.c. > Also, rename it to ->ip_local_ports instead. > > Cc: David S. Miller > Cc: Francois Romieu > Reported-by: Stefan de Konink > Signed-off-by: Cong Wang I think these two changes fix fairly serious issues that have existed for some time, so it should go into 'net', do you agree?