From: David Miller <davem@davemloft.net>
To: romieu@fr.zoreil.com
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv4: move local_port_range out of CONFIG_SYSCTL
Date: Thu, 08 May 2014 22:52:21 -0400 (EDT) [thread overview]
Message-ID: <20140508.225221.188940173991264163.davem@davemloft.net> (raw)
In-Reply-To: <20140507224848.GA1272@electric-eye.fr.zoreil.com>
From: Francois Romieu <romieu@fr.zoreil.com>
Date: Thu, 8 May 2014 00:48:48 +0200
> David Miller <davem@davemloft.net> :
> [...]
>> I think these two changes fix fairly serious issues that have existed for some
>> time, so it should go into 'net', do you agree?
>
> Patch #1, yes.
>
> Without patch #2, the root group id is always granted ping init when
> CONFIG_SYSCTL is not set. It's more cautious than serious.
Still, initializing such fundamental values to different defaults
based upon whether SYSCTL is enabled or not is pretty bad, so I've
decided to apply both patches to 'net'.
Thanks.
next prev parent reply other threads:[~2014-05-09 2:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 18:02 [PATCH net-next 1/2] ipv4: move local_port_range out of CONFIG_SYSCTL Cong Wang
2014-05-06 18:02 ` [PATCH net-next 2/2] ping: move ping_group_range " Cong Wang
2014-05-09 2:52 ` David Miller
2014-05-07 21:26 ` [PATCH net-next 1/2] ipv4: move local_port_range " David Miller
2014-05-07 22:48 ` Francois Romieu
2014-05-09 2:52 ` David Miller [this message]
2014-05-09 5:17 ` Cong Wang
2014-05-09 2:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140508.225221.188940173991264163.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).