* [PATCH 0/7] net: Checksum offload changes - Part II
@ 2014-05-07 23:51 Tom Herbert
2014-05-09 3:48 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tom Herbert @ 2014-05-07 23:51 UTC (permalink / raw)
To: davem, netdev
I am working on overhauling RX checksum offload. Goals of this effort
are:
- Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
- Preserve CHECKSUM_COMPLETE through encapsulation layers
- Don't do skb_checksum more than once per packet
- Unify GRO and non-GRO csum verification as much as possible
- Unify the checksum functions (checksum_init)
- Simply code
What is in this second patch set:
- Call common inet checksum validation functions in ICMP{4,6},
GRE{4,6}, and IGMP.
- In UDP, verify checksum before handing off to encap_rcv.
- Remove custom UDP checksum validation code in L2TP.
Please review carefully and test if possible, mucking with basic
checksum functions is always a little precarious :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/7] net: Checksum offload changes - Part II
2014-05-07 23:51 [PATCH 0/7] net: Checksum offload changes - Part II Tom Herbert
@ 2014-05-09 3:48 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-09 3:48 UTC (permalink / raw)
To: therbert; +Cc: netdev
From: Tom Herbert <therbert@google.com>
Date: Wed, 7 May 2014 16:51:33 -0700 (PDT)
> I am working on overhauling RX checksum offload. Goals of this effort
> are:
>
> - Specify what exactly it means when driver returns CHECKSUM_UNNECESSARY
> - Preserve CHECKSUM_COMPLETE through encapsulation layers
> - Don't do skb_checksum more than once per packet
> - Unify GRO and non-GRO csum verification as much as possible
> - Unify the checksum functions (checksum_init)
> - Simply code
>
> What is in this second patch set:
>
> - Call common inet checksum validation functions in ICMP{4,6},
> GRE{4,6}, and IGMP.
> - In UDP, verify checksum before handing off to encap_rcv.
> - Remove custom UDP checksum validation code in L2TP.
>
> Please review carefully and test if possible, mucking with basic
> checksum functions is always a little precarious :-)
This looks good to me, applied, thanks Tom.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-09 3:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-07 23:51 [PATCH 0/7] net: Checksum offload changes - Part II Tom Herbert
2014-05-09 3:48 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).