From: David Miller <davem@davemloft.net>
To: bh74.an@samsung.com
Cc: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
ks.giri@samsung.com, vipul.pandya@samsung.com
Subject: Re: [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support
Date: Mon, 12 May 2014 00:57:00 -0400 (EDT) [thread overview]
Message-ID: <20140512.005700.1622310019794083211.davem@davemloft.net> (raw)
In-Reply-To: <003a01cf6b2a$e7bf5bf0$b73e13d0$%an@samsung.com>
From: Byungho An <bh74.an@samsung.com>
Date: Fri, 09 May 2014 11:03:43 +0900
> This series added
> - functions to update rx descriptor tail pointer
> - non burst mode support
> - fixed dma channel feature.
This description is not sufficient.
I don't understand what non fixed burst mode means, and why
it is so critical to add support for it in 'net' which is
only for bug fixes.
I also do not understand what the "mtl and dma channel" feature is,
what was wrong with it, and what exactly patch #3 is doing to fix it.
Finally, I have no idea why the tail pointer update is necessary
and what problem it is fixing.
You have several things to address in this patch series before I
can apply it.
Furthermore, you have to make it clear what tree you intend these
changes to go into. 'net' is only for bug fixes, and 'net-next'
is for cleanups and new features.
Thank you.
prev parent reply other threads:[~2014-05-12 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 2:03 [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support Byungho An
2014-05-12 4:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512.005700.1622310019794083211.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bh74.an@samsung.com \
--cc=ks.giri@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vipul.pandya@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).