netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support
@ 2014-05-09  2:03 Byungho An
  2014-05-12  4:57 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Byungho An @ 2014-05-09  2:03 UTC (permalink / raw)
  To: 'netdev', linux-samsung-soc
  Cc: davem, 'ks.giri', 'vipul.pandya'

This series added 
- functions to update rx descriptor tail pointer 
- non burst mode support
- fixed dma channel feature.


Byungho An (3):
  net: sxgbe: Added condition for non fix_burst mode
  net: sxgbe: Added tail point update
  net: sxgbe: Fixed mtl and dma channel feature

 drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c  |   46 +++++++++++++++++++++--
 drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.h  |    6 ++-
 drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c |   21 ++++++++---
 3 files changed, 63 insertions(+), 10 deletions(-)

--
1.7.10.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support
  2014-05-09  2:03 [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support Byungho An
@ 2014-05-12  4:57 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-12  4:57 UTC (permalink / raw)
  To: bh74.an; +Cc: netdev, linux-samsung-soc, ks.giri, vipul.pandya

From: Byungho An <bh74.an@samsung.com>
Date: Fri, 09 May 2014 11:03:43 +0900

> This series added 
> - functions to update rx descriptor tail pointer 
> - non burst mode support
> - fixed dma channel feature.

This description is not sufficient.

I don't understand what non fixed burst mode means, and why
it is so critical to add support for it in 'net' which is
only for bug fixes.

I also do not understand what the "mtl and dma channel" feature is,
what was wrong with it, and what exactly patch #3 is doing to fix it.

Finally, I have no idea why the tail pointer update is necessary
and what problem it is fixing.

You have several things to address in this patch series before I
can apply it.

Furthermore, you have to make it clear what tree you intend these
changes to go into.  'net' is only for bug fixes, and 'net-next'
is for cleanups and new features.

Thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-05-12  4:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-09  2:03 [PATCH 0/3] net: sxgbe: Added dma related function and non-burst mode support Byungho An
2014-05-12  4:57 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).