From: David Miller <davem@davemloft.net>
To: rdunlap@infradead.org
Cc: netdev@vger.kernel.org, ariele@broadcom.com
Subject: Re: [PATCH] bnx2x: fix build when BNX2X_SRIOV is not enabled
Date: Tue, 13 May 2014 13:09:04 -0400 (EDT) [thread overview]
Message-ID: <20140513.130904.491541552382684334.davem@davemloft.net> (raw)
In-Reply-To: <536E7112.4080506@infradead.org>
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sat, 10 May 2014 11:33:54 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build when BNX2X_SRIOV is not enabled.
> Change one parameter struct from bnx2 to bnx2x and don't return a value
> from a void function.
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:576:48: warning: 'struct bnx2' declared inside parameter list [enabled by default]
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:576:48: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
>
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.h:576:60: warning: 'return' with a value, in function returning void [enabled by default]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks Randy.
prev parent reply other threads:[~2014-05-13 17:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 18:33 [PATCH] bnx2x: fix build when BNX2X_SRIOV is not enabled Randy Dunlap
2014-05-13 17:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513.130904.491541552382684334.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ariele@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).