* [patch] net, filter: make new test_bpf depend on networking
@ 2014-05-13 19:57 David Rientjes
2014-05-13 20:07 ` Alexei Starovoitov
2014-05-13 21:13 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David Rientjes @ 2014-05-13 19:57 UTC (permalink / raw)
To: David S. Miller; +Cc: Alexei Starovoitov, netdev, linux-kernel
CONFIG_TEST_BPF depends on CONFIG_NET, otherwise the build fails:
ERROR: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
ERROR: "kfree_skb" [lib/test_bpf.ko] undefined!
ERROR: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
ERROR: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
ERROR: "__alloc_skb" [lib/test_bpf.ko] undefined!
Add the dependency.
Cc: Alexei Starovoitov <ast@plumgrid.com>
Signed-off-by: David Rientjes <rientjes@google.com>
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1639,6 +1639,7 @@ config TEST_USER_COPY
config TEST_BPF
tristate "Test BPF filter functionality"
default n
+ depends on NET
depends on m
help
This builds the "test_bpf" module that runs various test vectors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] net, filter: make new test_bpf depend on networking
2014-05-13 19:57 [patch] net, filter: make new test_bpf depend on networking David Rientjes
@ 2014-05-13 20:07 ` Alexei Starovoitov
2014-05-13 21:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Alexei Starovoitov @ 2014-05-13 20:07 UTC (permalink / raw)
To: David Rientjes; +Cc: David S. Miller, Network Development, LKML
On Tue, May 13, 2014 at 12:57 PM, David Rientjes <rientjes@google.com> wrote:
> CONFIG_TEST_BPF depends on CONFIG_NET, otherwise the build fails:
>
> ERROR: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> ERROR: "kfree_skb" [lib/test_bpf.ko] undefined!
> ERROR: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> ERROR: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> ERROR: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Add the dependency.
>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
commit 98920ba6911c7 ("net: fix test_bpf build to depend on NET")
is already in net-next.
Sorry about the breakage.
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1639,6 +1639,7 @@ config TEST_USER_COPY
> config TEST_BPF
> tristate "Test BPF filter functionality"
> default n
> + depends on NET
> depends on m
> help
> This builds the "test_bpf" module that runs various test vectors
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] net, filter: make new test_bpf depend on networking
2014-05-13 19:57 [patch] net, filter: make new test_bpf depend on networking David Rientjes
2014-05-13 20:07 ` Alexei Starovoitov
@ 2014-05-13 21:13 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-13 21:13 UTC (permalink / raw)
To: rientjes; +Cc: ast, netdev, linux-kernel
From: David Rientjes <rientjes@google.com>
Date: Tue, 13 May 2014 12:57:56 -0700 (PDT)
> CONFIG_TEST_BPF depends on CONFIG_NET, otherwise the build fails:
>
> ERROR: "sk_unattached_filter_destroy" [lib/test_bpf.ko] undefined!
> ERROR: "kfree_skb" [lib/test_bpf.ko] undefined!
> ERROR: "sk_unattached_filter_create" [lib/test_bpf.ko] undefined!
> ERROR: "sk_run_filter_int_skb" [lib/test_bpf.ko] undefined!
> ERROR: "__alloc_skb" [lib/test_bpf.ko] undefined!
>
> Add the dependency.
>
> Cc: Alexei Starovoitov <ast@plumgrid.com>
> Signed-off-by: David Rientjes <rientjes@google.com>
I just applied a patch from Randy Dunlap that does the same thing,
thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 21:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 19:57 [patch] net, filter: make new test_bpf depend on networking David Rientjes
2014-05-13 20:07 ` Alexei Starovoitov
2014-05-13 21:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).