From: Steffen Klassert <steffen.klassert@secunet.com>
To: Mathias Krause <minipli@googlemail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH ipsec 1/3] vti6: Don't unregister pernet ops twice on init errors
Date: Tue, 13 May 2014 10:35:55 +0200 [thread overview]
Message-ID: <20140513083554.GY32371@secunet.com> (raw)
In-Reply-To: <1399671822-12842-2-git-send-email-minipli@googlemail.com>
On Fri, May 09, 2014 at 11:43:40PM +0200, Mathias Krause wrote:
> If we fail to register one of the xfrm protocol handlers we will
> unregister the pernet ops twice on the error exit path. This will
> probably lead to a kernel panic as the double deregistration
> leads to a double kfree().
>
> Fix this by removing one of the calls to do it only once.
>
> Fixes: fa9ad96d49 ("vti6: Update the ipv6 side to use its own...")
> Signed-off-by: Mathias Krause <minipli@googlemail.com>
Applied to the ipsec tree, thanks!
next prev parent reply other threads:[~2014-05-13 8:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:43 [PATCH ipsec 0/3] vti/vti6: minor tweaks + one fix Mathias Krause
2014-05-09 21:43 ` [PATCH ipsec 1/3] vti6: Don't unregister pernet ops twice on init errors Mathias Krause
2014-05-13 8:35 ` Steffen Klassert [this message]
2014-05-09 21:43 ` [PATCH ipsec 2/3] vti6: Simplify error handling in module init and exit Mathias Krause
2014-05-09 21:43 ` [PATCH ipsec 3/3] vti: " Mathias Krause
2014-05-13 8:41 ` [PATCH ipsec 0/3] vti/vti6: minor tweaks + one fix Steffen Klassert
2014-05-13 20:38 ` Mathias Krause
2014-06-30 9:19 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513083554.GY32371@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=minipli@googlemail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).