* [PATCH net v1] af_iucv: wrong mapping of sent and confirmed skbs
@ 2014-05-13 12:38 Frank Blaschka
2014-05-14 19:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Frank Blaschka @ 2014-05-13 12:38 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-s390, stable
From: Ursula Braun <ursula.braun@de.ibm.com>
When sending data through IUCV a MESSAGE COMPLETE interrupt
signals that sent data memory can be freed or reused again.
With commit f9c41a62bba3f3f7ef3541b2a025e3371bcbba97
"af_iucv: fix recvmsg by replacing skb_pull() function" the
MESSAGE COMPLETE callback iucv_callback_txdone() identifies
the wrong skb as being confirmed, which leads to data corruption.
This patch fixes the skb mapping logic in iucv_callback_txdone().
Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Cc: <stable@vger.kernel.org>
---
net/iucv/af_iucv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -1830,7 +1830,7 @@ static void iucv_callback_txdone(struct
spin_lock_irqsave(&list->lock, flags);
while (list_skb != (struct sk_buff *)list) {
- if (msg->tag != IUCV_SKB_CB(list_skb)->tag) {
+ if (msg->tag == IUCV_SKB_CB(list_skb)->tag) {
this = list_skb;
break;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net v1] af_iucv: wrong mapping of sent and confirmed skbs
2014-05-13 12:38 [PATCH net v1] af_iucv: wrong mapping of sent and confirmed skbs Frank Blaschka
@ 2014-05-14 19:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-14 19:38 UTC (permalink / raw)
To: blaschka; +Cc: netdev, linux-s390, stable
From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Date: Tue, 13 May 2014 14:38:02 +0200
> From: Ursula Braun <ursula.braun@de.ibm.com>
>
> When sending data through IUCV a MESSAGE COMPLETE interrupt
> signals that sent data memory can be freed or reused again.
> With commit f9c41a62bba3f3f7ef3541b2a025e3371bcbba97
> "af_iucv: fix recvmsg by replacing skb_pull() function" the
> MESSAGE COMPLETE callback iucv_callback_txdone() identifies
> the wrong skb as being confirmed, which leads to data corruption.
> This patch fixes the skb mapping logic in iucv_callback_txdone().
>
> Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com>
> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-14 19:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-13 12:38 [PATCH net v1] af_iucv: wrong mapping of sent and confirmed skbs Frank Blaschka
2014-05-14 19:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).