From: Werner Almesberger <werner@almesberger.net>
To: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH net-next 3/5] ieee802154: change _cb handling slightly
Date: Tue, 13 May 2014 16:25:07 -0300 [thread overview]
Message-ID: <20140513192507.GA12817@ws> (raw)
In-Reply-To: <1400001846-5349-4-git-send-email-phoebe.buckheister@itwm.fraunhofer.de>
Phoebe Buckheister wrote:
> +static inline struct ieee802154_mac_cb *mac_cb_alloc(struct sk_buff *skb)
That's a rather misleading name for a mere initialization.
How about mac_cb_init ?
The rest of this patch looks nice.
- Werner
next prev parent reply other threads:[~2014-05-13 19:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 17:24 [PATCH net-next 0/5] 802154: some cleanups and fixes Phoebe Buckheister
2014-05-13 17:24 ` [PATCH net-next 1/5] ieee802154: add definitions for link-layer security and header functions Phoebe Buckheister
2014-05-13 17:24 ` [PATCH net-next 2/5] 6lowpan: simplify/fix payload length calculation Phoebe Buckheister
[not found] ` <1400001846-5349-3-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-05-14 5:27 ` Alexander Aring
[not found] ` <1400001846-5349-1-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-05-13 17:24 ` [PATCH net-next 3/5] ieee802154: change _cb handling slightly Phoebe Buckheister
2014-05-13 19:25 ` Werner Almesberger [this message]
2014-05-13 17:24 ` [PATCH net-next 4/5] ieee802154: don't ignore "to" argument in unbound dgram sendmsg Phoebe Buckheister
[not found] ` <1400001846-5349-5-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-05-13 20:13 ` Werner Almesberger
2014-05-13 20:25 ` [Linux-zigbee-devel] " Phoebe Buckheister
2014-05-13 17:24 ` [PATCH net-next 5/5] mac802154: make mac802154_wpan_open static Phoebe Buckheister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140513192507.GA12817@ws \
--to=werner@almesberger.net \
--cc=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=phoebe.buckheister@itwm.fraunhofer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).