From: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-zigbee-devel@lists.sourceforge.net
Subject: Re: [Linux-zigbee-devel] [PATCH net-next 4/6] 6lowpan: fix fragmentation
Date: Wed, 14 May 2014 18:06:10 +0200 [thread overview]
Message-ID: <20140514180610.31293ff0@zoidberg> (raw)
In-Reply-To: <20140514155503.GA14689@omega>
On Wed, 14 May 2014 17:56:57 +0200
Alexander Aring <alex.aring@gmail.com> wrote:
> > +
> > + frag = alloc_skb(real_dev->hard_header_len +
> > + real_dev->needed_tailroom + size,
> > + GFP_ATOMIC);
>
> Why not keep netdev_alloc_skb for the real_dev?
>
> But then we need to use dev_kfree_skb.
Because netdev_alloc_skb allocates "for RX", which uses different
allocation flags internally and might do the wrong thing when memory
is tight.
Also, all skb free funtions are essentially the same, where
dev_kfree_skb == kfree_skb by a macro definition, and what remains
differs pretty much only in how it shows up in traces. They all call
__kfree_skb internally.
>
> - Alex
next prev parent reply other threads:[~2014-05-14 16:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:43 [PATCH net-next v2 0/6] 802154: some cleanups and fixes Phoebe Buckheister
2014-05-14 15:43 ` [PATCH net-next 1/6] ieee802154: add definitions for link-layer security and header functions Phoebe Buckheister
2014-05-14 15:43 ` [PATCH net-next 3/6] ieee802154: change _cb handling slightly Phoebe Buckheister
[not found] ` <1400082191-16493-1-git-send-email-phoebe.buckheister-mPn0NPGs4xGatNDF+KUbs4QuADTiUCJX@public.gmane.org>
2014-05-14 15:43 ` [PATCH net-next 2/6] mac802154: account for all header parts during wpan header creationg Phoebe Buckheister
2014-05-14 15:43 ` [PATCH net-next 4/6] 6lowpan: fix fragmentation Phoebe Buckheister
2014-05-14 15:56 ` [Linux-zigbee-devel] " Alexander Aring
2014-05-14 16:06 ` Phoebe Buckheister [this message]
2014-05-14 15:43 ` [PATCH net-next 5/6] ieee802154: fix dgram socket sendmsg() Phoebe Buckheister
2014-05-14 15:43 ` [PATCH net-next 6/6] mac802154: make mac802154_wpan_open static Phoebe Buckheister
2014-05-15 19:52 ` [PATCH net-next v2 0/6] 802154: some cleanups and fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514180610.31293ff0@zoidberg \
--to=phoebe.buckheister@itwm.fraunhofer.de \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).