From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
cwang@twopensource.com, ebiederm@xmission.com
Subject: Re: [PATCH net v2] rtnetlink: wait for unregistering devices in rtnl_link_unregister()
Date: Thu, 15 May 2014 15:31:21 -0400 (EDT) [thread overview]
Message-ID: <20140515.153121.1605947735072984728.davem@davemloft.net> (raw)
In-Reply-To: <20140515.145043.2164782223537934866.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Thu, 15 May 2014 14:50:43 -0400 (EDT)
> From: Cong Wang <xiyou.wangcong@gmail.com>
> Date: Thu, 15 May 2014 11:43:26 -0700
>
>> On Thu, May 15, 2014 at 11:32 AM, David Miller <davem@davemloft.net> wrote:
>>> From: Cong Wang <xiyou.wangcong@gmail.com>
>>> Date: Mon, 12 May 2014 15:11:20 -0700
>>>
>>>> +static void rtnl_lock_unregistering_all(void)
>>>
>>> This is just:
>>>
>>> rtnl_lock_unregistering(&net_namespace_list);
>>>
>>> There is no need to reimplement the entire thing.
>>
>> This is exactly what I did in v0 (never sent out) locally,
>> I spent few hours to debug the problem. The problem
>> is net_namespace_list links netns by net->list,
>> while rtnl_lock_unregistering() uses net->exit_list.
>> Thus I used an ugly macro in v1.
>>
>> There seems no other choice than between
>> an ugly macro and duplicated code.
>
> Thanks for explaining (again), I'll look at this some more.
Ok, applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-05-15 19:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 22:11 [PATCH net v2] rtnetlink: wait for unregistering devices in rtnl_link_unregister() Cong Wang
2014-05-15 18:32 ` David Miller
2014-05-15 18:43 ` Cong Wang
2014-05-15 18:50 ` David Miller
2014-05-15 19:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515.153121.1605947735072984728.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).