From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 2/4] net/ariadne: delete unneeded call to netdev_priv Date: Thu, 15 May 2014 16:58:10 -0400 (EDT) Message-ID: <20140515.165810.1301594950523192843.davem@davemloft.net> References: <1400125401-15512-2-git-send-email-Julia.Lawall@lip6.fr> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: Julia.Lawall@lip6.fr Return-path: In-Reply-To: <1400125401-15512-2-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Julia Lawall Date: Thu, 15 May 2014 05:43:19 +0200 > From: Julia Lawall > > Netdev_priv is an accessor function, and has no purpose if its result is > not used. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ local idexpression x; @@ > -x = netdev_priv(...); > ... when != x > // > > Signed-off-by: Julia Lawall Applied.