From: David Miller <davem@davemloft.net>
To: steffen.klassert@secunet.com
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: pull request (net): ipsec 2014-05-15
Date: Thu, 15 May 2014 23:25:16 -0400 (EDT) [thread overview]
Message-ID: <20140515.232516.1168321577530105610.davem@davemloft.net> (raw)
In-Reply-To: <1400137676-27565-1-git-send-email-steffen.klassert@secunet.com>
From: Steffen Klassert <steffen.klassert@secunet.com>
Date: Thu, 15 May 2014 09:07:50 +0200
> This pull request has a merge conflict in net/ipv4/ip_vti.c
> between commit 8d89dcdf80d8 ("vti: don't allow to add the same
> tunnel twice") and commit a32452366b72 ("vti4:Don't count header
> length twice"). It can be solved like it is done in linux-next.
>
> 1) Fix a ipv6 xfrm output crash when a packet is rerouted
> by netfilter to not use IPsec.
>
> 2) vti4 counts some header lengths twice leading to an incorrect
> device mtu. Fix this by counting these headers only once.
>
> 3) We don't catch the case if an unsupported protocol is submitted
> to the xfrm protocol handlers, this can lead to NULL pointer
> dereferences. Fix this by adding the appropriate checks.
>
> 4) vti6 may unregister pernet ops twice on init errors.
> Fix this by removing one of the calls to do it only once.
> From Mathias Krause.
>
> 5) Set the vti tunnel mark before doing a lookup in the error
> handlers. Otherwise we don't find the correct xfrm state.
>
> Please pull or let me know if there are problems.
Pulled, thanks a lot Steffen.
prev parent reply other threads:[~2014-05-16 3:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 7:07 pull request (net): ipsec 2014-05-15 Steffen Klassert
2014-05-15 7:07 ` [PATCH 1/6] xfrm: Fix crash with ipv6 IPsec tunnel and NAT Steffen Klassert
2014-05-15 7:07 ` [PATCH 2/6] vti4: Don't count header length twice Steffen Klassert
2014-05-15 7:07 ` [PATCH 3/6] xfrm4: Properly handle unsupported protocols Steffen Klassert
2014-05-15 7:07 ` [PATCH 4/6] xfrm6: " Steffen Klassert
2014-05-15 7:07 ` [PATCH 5/6] vti6: Don't unregister pernet ops twice on init errors Steffen Klassert
2014-05-15 7:07 ` [PATCH 6/6] vti: Use the tunnel mark for lookup in the error handlers Steffen Klassert
2014-05-16 3:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140515.232516.1168321577530105610.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).