netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl
@ 2014-05-15 11:35 Nikolay Aleksandrov
  2014-05-15 11:44 ` Veaceslav Falico
  2014-05-16  3:37 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Nikolay Aleksandrov @ 2014-05-15 11:35 UTC (permalink / raw)
  To: netdev; +Cc: Nikolay Aleksandrov, Jay Vosburgh, Veaceslav Falico,
	Andy Gospodarek

I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
it with the conversion of arp_interval so add it now.

CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Veaceslav Falico <vfalico@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>

Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new
option API")
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
---
 drivers/net/bonding/bond_options.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
index 724e30fa20b9..832070298446 100644
--- a/drivers/net/bonding/bond_options.c
+++ b/drivers/net/bonding/bond_options.c
@@ -125,6 +125,7 @@ static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
 static const struct bond_opt_value bond_intmax_tbl[] = {
 	{ "off",     0,       BOND_VALFLAG_DEFAULT},
 	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
+	{ NULL,      -1,      0}
 };
 
 static const struct bond_opt_value bond_lacp_rate_tbl[] = {
-- 
1.8.5.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl
  2014-05-15 11:35 [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl Nikolay Aleksandrov
@ 2014-05-15 11:44 ` Veaceslav Falico
  2014-05-16  3:37 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Veaceslav Falico @ 2014-05-15 11:44 UTC (permalink / raw)
  To: Nikolay Aleksandrov; +Cc: netdev, Jay Vosburgh, Andy Gospodarek

On Thu, May 15, 2014 at 01:35:23PM +0200, Nikolay Aleksandrov wrote:
>I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
>it with the conversion of arp_interval so add it now.
>
>CC: Jay Vosburgh <j.vosburgh@gmail.com>
>CC: Veaceslav Falico <vfalico@gmail.com>

Acked-by: Veaceslav Falico <vfalico@gmail.com>

>CC: Andy Gospodarek <andy@greyhouse.net>
>
>Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new
>option API")
>Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
>---
> drivers/net/bonding/bond_options.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c
>index 724e30fa20b9..832070298446 100644
>--- a/drivers/net/bonding/bond_options.c
>+++ b/drivers/net/bonding/bond_options.c
>@@ -125,6 +125,7 @@ static const struct bond_opt_value bond_fail_over_mac_tbl[] = {
> static const struct bond_opt_value bond_intmax_tbl[] = {
> 	{ "off",     0,       BOND_VALFLAG_DEFAULT},
> 	{ "maxval",  INT_MAX, BOND_VALFLAG_MAX},
>+	{ NULL,      -1,      0}
> };
>
> static const struct bond_opt_value bond_lacp_rate_tbl[] = {
>-- 
>1.8.5.3
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl
  2014-05-15 11:35 [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl Nikolay Aleksandrov
  2014-05-15 11:44 ` Veaceslav Falico
@ 2014-05-16  3:37 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-05-16  3:37 UTC (permalink / raw)
  To: nikolay; +Cc: netdev, j.vosburgh, vfalico, andy

From: Nikolay Aleksandrov <nikolay@redhat.com>
Date: Thu, 15 May 2014 13:35:23 +0200

> I've missed to add a NULL entry to the bond_intmax_tbl when I introduced
> it with the conversion of arp_interval so add it now.
> 
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> 
> Fixes: 7bdb04ed0dbf ("bonding: convert arp_interval to use the new option API")
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>

Applied and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-16  3:37 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-15 11:35 [PATCH net] bonding: fix out of range parameters for bond_intmax_tbl Nikolay Aleksandrov
2014-05-15 11:44 ` Veaceslav Falico
2014-05-16  3:37 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).